Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my profile, more than 80% time is spent in the loop of strided accessor construction when loading GLTF/GLB files.
I thus applied
np.lib.stride_tricks.as_strided
to speed up the process.I tested it on multiple glb files and the results are the same as the original logic.
This implementation also works for
stride = 0
, repeating the first element forcount
times. But glTF 2.0 specification 5.11.4 says it should be positive, so I added an assertion.