Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blender_boolean.py.tmpl #2314

Closed
wants to merge 1 commit into from
Closed

Conversation

Hellseher
Copy link

Fix build.

@mikedh
Copy link
Owner

mikedh commented Nov 5, 2024

Thanks for the PR! What was the crash you were seeing?

self.replacement["MESH_PRE"] = str([i.name for i in self.mesh_pre])

So this should be evaluated in the template to:
mesh_pre = ["file_name_a", "file_name_b"]

Where wouldn't this change emit:
mesh_pre = '["file_name_a", "file_name_b"]'

Which then the loop would be through characters of the string, rather than file names?

@Hellseher
Copy link
Author

Hi,

I've checked the history of updates which Guix index has, it looks like it was
valid on 3.10.7, which I can't reproduce it after upgrade to the 4.5.2. It might
be "self healed" between versions :-)

The link to a commit where the package was added https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b4b93035c1c4dda16b8399fc77b6ef150831ef1d

Thanks,
Oleg

@mikedh
Copy link
Owner

mikedh commented Nov 9, 2024

I tried this in a branch and it fails test_boolean for the reasons above. I think the guix package can probably update to the latest trimesh, and remove that patch. I recently added blender back to the docker tests so if you pull in main to this PR it should also be caught in CI:

usr/lib/python3.12/subprocess.py:571: CalledProcessError
=========================== short test summary info ============================
FAILED test_boolean.py::test_boolean - subprocess.CalledProcessError: Command '['/home/mikedh/.local/bin/blender',...
FAILED test_boolean.py::test_multiple - subprocess.CalledProcessError: Command '['/home/mikedh/.local/bin/blender',...
FAILED test_boolean.py::test_empty - subprocess.CalledProcessError: Command '['/home/mikedh/.local/bin/blender',...
FAILED test_boolean.py::test_multiple_difference - subprocess.CalledProcessError: Command '['/home/mikedh/.local/bin/blender',...
========================= 4 

Thanks for the followup from GUIX!

@mikedh mikedh closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants