Adding thresholding option to matrix_to_marching_cubes() #2320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that it was a bit of an annoying pre-processing step to convert my numpy arrays to Boolean arrays before using the ops.matrix_to_marching_cubes function. I think adding an optional arg for setting a threshold could be a quality of life improvement.
In this implementation 'threshold' is None by default but if a float or int is passed, that value is used to binarize the input matrix. It converts every Element > Threshold to True and then works the same way as the existing version of the function.