Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing payload entity configuration and metric #12

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mikefero
Copy link
Owner

@mikefero mikefero commented Aug 2, 2024

This feature add a new on-demand metric for nodes when a required entity is missing from the config_table. This information is also stored with the node in the in-memory database and can be seen (if triggered) in the response for nodes and groups.

This feature add a new on-demand metric for nodes when a required entity
is missing from the config_table. This information is also stored with
the node in the in-memory database and can be seen (if triggered) in the
response for nodes and groups.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.83333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 62.50%. Comparing base (f9a9888) to head (a6d7930).

Files Patch % Lines
internal/monitoring/monitoring.go 50.00% 16 Missing and 1 partial ⚠️
node/protocol_handler_standard.go 70.00% 6 Missing and 3 partials ⚠️
internal/config/config.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   62.53%   62.50%   -0.03%     
==========================================
  Files          13       13              
  Lines        1340     1379      +39     
==========================================
+ Hits          838      862      +24     
- Misses        405      415      +10     
- Partials       97      102       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikefero mikefero merged commit f97ba45 into main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants