feat: add the ability to group instances between node definitions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows for grouping instances between single or multiple
node definitions. Assigning the group is optional and if set will modify
the logger created for the node to include the group assigned. The
responses have been updated to include the group or when retrieving the
hosts the groups that the host has associated with it.
The responses have been updated to remove the use of the API definitions
that are generated from the openapi in order for future versioned
RESTful API to be implemented. All tests have been updated to use
generic map[string]interface{} defined values where applicable for
complete end-to-end testing.
The database was also updated to add a GetHostsByGroup method with
corresponding index that will open up the API for the versioned API.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 66.00% 65.87% -0.14%
==========================================
Files 10 10
Lines 809 879 +70
==========================================
+ Hits 534 579 +45
- Misses 222 237 +15
- Partials 53 63 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows for grouping instances between single or multiple node definitions. Assigning the group is optional and if set will modify the logger created for the node to include the group assigned. The responses have been updated to include the group or when retrieving the hosts the groups that the host has associated with it.
The responses have been updated to remove the use of the API definitions that are generated from the openapi in order for future versioned RESTful API to be implemented. All tests have been updated to use generic map[string]interface{} defined values where applicable for complete end-to-end testing.
The database was also updated to add a GetHostsByGroup method with corresponding index that will open up the API for the versioned API.
Go version was also updated to v1.22.5.