Adjacent words: prevent the same token matching with itself (#44)

mikegoatly · Feb 11, 2022 · 16776df · 16776df
1 parent 0ae4424
commit 16776df
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -10,7 +10,7 @@ trigger:
 variables:
   majorVersion: 3
   minorVersion: 0
-  patchVersion: 0
+  patchVersion: 1
   project: src/Lifti.Core/Lifti.Core.csproj
   testProject: test/Lifti.Tests/Lifti.Tests.csproj
   buildConfiguration: 'Release'

diff --git a/src/Lifti.Core/Lifti.Core.csproj b/src/Lifti.Core/Lifti.Core.csproj
@@ -15,7 +15,6 @@
     <PackageId>Lifti.Core</PackageId>
     <Copyright>Mike Goatly</Copyright>
     <PackageLicenseFile></PackageLicenseFile>
-    <PackageReleaseNotes>First version of the new rewrite</PackageReleaseNotes>
     <AssemblyName>Lifti.Core</AssemblyName>
     <LangVersion>8.0</LangVersion>
     <Nullable>enable</Nullable>

diff --git a/src/Lifti.Core/Querying/IntegerExtensions.cs b/src/Lifti.Core/Querying/IntegerExtensions.cs
@@ -4,7 +4,7 @@ internal static class IntegerExtensions
     {
         internal static bool IsPositiveAndLessThanOrEqualTo(this int value, int target)
         {
-            return value >= 0 && value <= target;
+            return value > 0 && value <= target;
         }
     }
 }
diff --git a/test/Lifti.Tests/Querying/QueryParts/AdjacentWordsQueryOperatorTests.cs b/test/Lifti.Tests/Querying/QueryParts/AdjacentWordsQueryOperatorTests.cs
@@ -44,5 +44,22 @@ public void ShouldOnlyReturnMatchesForAppropriateField()
                 },
                 config => config.AllowingInfiniteRecursion());
         }
+
+        [Fact]
+        public void ShouldNotCombineSameTokensTogether()
+        {
+            var sut = new AdjacentWordsQueryOperator(
+                new[] {
+                    new FakeQueryPart(
+                        ScoredToken(7, ScoredFieldMatch(1D, 1, 8, 20, 100))),
+                    new FakeQueryPart(
+                        ScoredToken(7, ScoredFieldMatch(1D, 1, 8, 20, 100)))
+                    });
+
+            var results = sut.Evaluate(() => new FakeIndexNavigator(), QueryContext.Empty);
+
+            // The first and second query parts should not combine together
+            results.Matches.Should().BeEmpty();
+        }
     }
 }