Merge pull request #251 from mikehaertl/249-fix-null-values

Issue #249 Fix infinite loop with null values in form data
mikehaertl · Jul 30, 2021 · 97b80fb · 97b80fb
2 parents 8a6fe16 + 31e5ec6
commit 97b80fb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/XfdfFile.php b/src/XfdfFile.php
@@ -184,7 +184,7 @@ protected function writeFields($fp, $fields)
             if (!is_array($value)) {
                 $value = array($value);
             }
-            if (isset($value[0])) {
+            if (array_key_exists(0, $value)) {
                 // Numeric keys: single or multi-value field
                 foreach($value as $val) {
                     $val = $this->xmlEncode($val);

diff --git a/tests/XfdfFileTest.php b/tests/XfdfFileTest.php
@@ -25,6 +25,7 @@ public function testXfdfFileCreation()
             'multivalue1' => array('val1', 'val2'),
             'nested.dummy' => 'valX',
             'nested.multivalue2' => array('val3', 'val4'),
+            'nullValue' => null,
         );
 
         $oXfdfFile = new XfdfFile($data, null, null, __DIR__);

diff --git a/tests/files/XfdfFileTest.xfdf b/tests/files/XfdfFileTest.xfdf
@@ -59,5 +59,8 @@
 <value>val4</value>
 </field>
 </field>
+<field name="nullValue">
+<value></value>
+</field>
 </fields>
 </xfdf>