Add a FIXME about the Banach laws. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for issue #19. The laws not being tested and their statuses are below: law_Banach_distance law_Bregman_nonnegativity law_Subtype_f1 |
The Banach laws are not being tested because they don't hold for Float and Double types. This commit adds a FIXME note so we don't forget to eventually add support for them.
cdepillabout
force-pushed
the
add-fixme-about-banach-laws
branch
from
83718e0
to
ff93cef
Compare
mikeizbicki
added a commit
that referenced
this pull request
Sep 10, 2015
Add a FIXME about the Banach laws.
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Banach laws are not being tested because they don't hold for Float
and Double types. This commit adds a FIXME note so we don't forget to
eventually add support for them.