Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added og:image tags and meta tags for twitter card #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added og:image tags and meta tags for twitter card #8

wants to merge 2 commits into from

Conversation

sonimadhuri
Copy link

No description provided.

@mikelax mikelax self-requested a review October 15, 2018 18:24
@@ -55,6 +55,17 @@ class Template extends React.Component {
property="og:description"
content="/spacebot - A Slack Bot that helps you learn and explore space. Learn about astronomy, NASA, mars rovers, and more."
/>
<meta property="og:image" content="https://raw.githubusercontent.com/mikelax/spacebot-site/master/src/assets/images/website-icon.png" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonimadhuri thanks for working on this, we will have to make a few additional change to get the correct URL to use for this tag and the corresponding twitter:image url.

We don't want to link to the github URL, but rather the generated URL should be an absolute URL based on the slashspacebot.com domain.

  • Add a siteUrl attribute to the siteMetadata attribute in the gatsby-config.js file. The value should be: https://slashspacebot.com
  • git mv the file website-icon.png to the static folder. Update the value for the iconattribute in gatsby-config.js to be:static/website-icon.png`
  • In layout.js, you can use graphql static query, tutorial here to get the siteUrl value with /website-icon.png. The resulting value for these should be: https://slashspacebot.com/website-icon.png

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mikelax I'm on this, But I am pretty new to graphql

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool. Let me know if you have any questions or if you want me to push a little sample for the graphql query, etc.

@mikelax
Copy link
Owner

mikelax commented Nov 1, 2018

Hey @sonimadhuri let me know if you need any help with this or want me to make the last few changes needed. thanks

@sonimadhuri
Copy link
Author

@mikelax Yeah it would be great if you can go ahead with changing the last bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants