[bilibili] bilibili User Articles FavList support #6781
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikf
reviewed
Feb 15, 2025
Comment on lines
+84
to
+85
| class BilibiliUserArticleFavlistExtractor(BilibiliExtractor): | ||
| subcategory = "user-article-favlist" |
There was a problem hiding this comment.
Suggested change
| class BilibiliUserArticleFavlistExtractor(BilibiliExtractor): | |
| subcategory = "user-article-favlist" | |
| class BilibiliUserArticlesFavoriteExtractor(BilibiliExtractor): | |
| subcategory = "user-articles-favorite" |
To stay consistent with the naming of the existing user-articles extractor and other favorite extractors
Comment on lines
+86
to
+88
| pattern = (r"(?:https?://)?(?:space.bilibili.com)" | ||
| r"/(\d+)/(?:favlist\?fid=opus)" | ||
| r"(?:&ftype=opus)?") |
There was a problem hiding this comment.
Suggested change
| pattern = (r"(?:https?://)?(?:space.bilibili.com)" | |
| r"/(\d+)/(?:favlist\?fid=opus)" | |
| r"(?:&ftype=opus)?") | |
| pattern = (r"(?:https?://)?space\.bilibili\.com" | |
| r"/(\d+)/favlist\?fid=opus") |
| pattern = (r"(?:https?://)?(?:space.bilibili.com)" | ||
| r"/(\d+)/(?:favlist\?fid=opus)" | ||
| r"(?:&ftype=opus)?") | ||
| example = "https://space.bilibili.com/123456/favlist?fid=opus" |
There was a problem hiding this comment.
Suggested change
| example = "https://space.bilibili.com/123456/favlist?fid=opus" | |
| example = "https://space.bilibili.com/12345/favlist?fid=opus" |
Example URL IDs are 12345 everywhere else.
| BilibiliExtractor._init(self) | ||
| if self._warning: | ||
| if not self.cookies_check(("SESSDATA",)): | ||
| self.log.warning("no 'SESSDATA' cookie set") |
There was a problem hiding this comment.
Suggested change
| self.log.warning("no 'SESSDATA' cookie set") | |
| self.log.error("'SESSDATA' cookie required") |
Comment on lines
+100
to
+102
| mid = self.api.login_user_id() | ||
| if str(mid) != self.groups[0]: | ||
| raise exception.StopExtraction("This is not you favlist url!") |
There was a problem hiding this comment.
I think doing an extra API request here is unnecessary. Just let the next API fail.
Comment on lines
+156
to
+164
| data = self._call(endpoint, params) | ||
|
|
||
| for item in data["data"]["items"]: | ||
| yield item | ||
|
|
||
| if not data["data"]["has_more"]: | ||
| break | ||
|
|
||
| params["page"] = params["page"] + 1 |
There was a problem hiding this comment.
Suggested change
| data = self._call(endpoint, params) | |
| for item in data["data"]["items"]: | |
| yield item | |
| if not data["data"]["has_more"]: | |
| break | |
| params["page"] = params["page"] + 1 | |
| data = self._call(endpoint, params)["data"] | |
| yield from data["items"] | |
| if not data.get("has_more"): | |
| break | |
| params["page"] += 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.