Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in which DISTINCT clauses were forcibly removed from supplied querysets #76

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ help: ## show help
install: ## install all requirements including for testing
pip install -r requirements-dev.txt

install-quite: ## same as install but pipes all output to /dev/null
install-quiet: ## same as install but pipes all output to /dev/null
pip install -r requirements-dev.txt > /dev/null

clean: clean-build clean-pyc ## remove all artifacts
Expand Down
3 changes: 2 additions & 1 deletion url_filter/backends/django.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ def filter_by_specs(self, queryset):
queryset = queryset.exclude(**{lookup: value})

to_many = self._is_any_to_many()
return queryset.distinct() if to_many and (include or exclude) else queryset
is_distinct = queryset.distinct()
bernd-wechner marked this conversation as resolved.
Show resolved Hide resolved
return queryset.distinct() if (not is_distinct) and to_many and (include or exclude) else queryset

def _is_any_to_many(self):
return any(self._is_to_many(self.model, i.components) for i in self.regular_specs)
Expand Down