Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project main rework #99

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Project main rework #99

merged 8 commits into from
Dec 19, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Dec 5, 2024

No description provided.

@lebrice lebrice force-pushed the project-main-rework branch from 563b79e to 833db23 Compare December 6, 2024 15:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 85.44304% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (91dde96) to head (4477811).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
project/experiment.py 78.48% 17 Missing ⚠️
project/conftest.py 50.00% 2 Missing ⚠️
project/main.py 93.33% 2 Missing ⚠️
project/trainers/jax_trainer.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   80.27%   80.21%   -0.06%     
==========================================
  Files          56       55       -1     
  Lines        3878     3872       -6     
==========================================
- Hits         3113     3106       -7     
- Misses        765      766       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review December 17, 2024 17:58
@lebrice lebrice requested a review from Copilot December 17, 2024 17:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • project/configs/config.py: Evaluated as low risk
  • project/algorithms/text_classifier.py: Evaluated as low risk
  • project/configs/datamodule/vision.yaml: Evaluated as low risk
  • project/configs/datamodule/glue_cola.yaml: Evaluated as low risk
  • project/configs/datamodule/mnist.yaml: Evaluated as low risk
  • project/configs/experiment/example.yaml: Evaluated as low risk
  • docs/profiling_test.py: Evaluated as low risk
  • project/configs/datamodule/cifar10.yaml: Evaluated as low risk
  • project/configs/datamodule/init.py: Evaluated as low risk
  • project/algorithms/testsuites/lightning_module_tests.py: Evaluated as low risk
  • project/conftest.py: Evaluated as low risk
  • project/configs/datamodule/fashion_mnist.yaml: Evaluated as low risk
  • project/configs/datamodule/imagenet.yaml: Evaluated as low risk
  • project/configs/datamodule/inaturalist.yaml: Evaluated as low risk
Comments suppressed due to low confidence (1)

project/algorithms/jax_ppo.py:835

  • The new evaluation function evaluate_ppo_example is not covered by tests. Please add a test case for this function to ensure its correctness.
@experiment.evaluate.register
Signed-off-by: Fabrice Normandin <[email protected]>
@lebrice lebrice merged commit bb1943d into master Dec 19, 2024
8 checks passed
@lebrice lebrice deleted the project-main-rework branch December 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants