-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project main rework #99
Conversation
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
563b79e
to
833db23
Compare
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 80.27% 80.21% -0.06%
==========================================
Files 56 55 -1
Lines 3878 3872 -6
==========================================
- Hits 3113 3106 -7
- Misses 765 766 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (14)
- project/configs/config.py: Evaluated as low risk
- project/algorithms/text_classifier.py: Evaluated as low risk
- project/configs/datamodule/vision.yaml: Evaluated as low risk
- project/configs/datamodule/glue_cola.yaml: Evaluated as low risk
- project/configs/datamodule/mnist.yaml: Evaluated as low risk
- project/configs/experiment/example.yaml: Evaluated as low risk
- docs/profiling_test.py: Evaluated as low risk
- project/configs/datamodule/cifar10.yaml: Evaluated as low risk
- project/configs/datamodule/init.py: Evaluated as low risk
- project/algorithms/testsuites/lightning_module_tests.py: Evaluated as low risk
- project/conftest.py: Evaluated as low risk
- project/configs/datamodule/fashion_mnist.yaml: Evaluated as low risk
- project/configs/datamodule/imagenet.yaml: Evaluated as low risk
- project/configs/datamodule/inaturalist.yaml: Evaluated as low risk
Comments suppressed due to low confidence (1)
project/algorithms/jax_ppo.py:835
- The new evaluation function
evaluate_ppo_example
is not covered by tests. Please add a test case for this function to ensure its correctness.
@experiment.evaluate.register
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
No description provided.