Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variable filter test insensitive to order. #1132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidbau
Copy link
Contributor

This test was previously sensitive to the order in which cg.variables is listed; now the test does not assume a particular ordering.

@davidbau
Copy link
Contributor Author

This test fails for me because cg.variables seems to be coming back in an order different from the one expected by the test. Maybe theano changed the order? I am using Theano 0.9.0.dev2.

@rizar
Copy link
Contributor

rizar commented Aug 1, 2016

Are you running the test on GPU? I assume so, because Travis seems to be quite happy with your PR.

Can you please share the error message with us, so that we know in which line the error happens?

@davidbau
Copy link
Contributor Author

davidbau commented Aug 1, 2016

Yes, I have gpu enabled. Not the right way to run tests?

Error message is just this:

$ nose2 tests.test_variable_filter
Using gpu device 0: GeForce GTX TITAN X (CNMeM is disabled, cuDNN 5005)
F..
======================================================================
FAIL: tests.test_variable_filter.FunctionTestCase (test_variable_filter)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/davidbau/git/blocks/tests/test_variable_filter.py", line 31, in test_variable_filter
    assert parameters == role_filter(cg.variables)
AssertionError

----------------------------------------------------------------------
Ran 3 tests in 0.072s

FAILED (failures=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants