Fix webpacker compatibility #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require 'webpacker/version' so that `Webpacker::VERSION` is accessible. And for consitency, require 'shakapacker/version' when using Shakapacker
rioug
force-pushed
the
1098-fix-webpacker-compatibility
branch
from
0fb0f7a to
12f5115
Compare
mathieujobin
approved these changes
Jan 25, 2024
unixmonkey
approved these changes
Jan 25, 2024
|
@unixmonkey Thanks for approving the PR ! I can see some the CI test failed but it doesn't seem to be related to the PR, should they be fixed ? |
|
This is now released in version 2.8.0 of the Wicked PDF gem. Thank you so much for your help! Please let me know if you have any issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explain in #1098 this PR #1067 broke compatibility with
WebpackerCause
The following line has been removed, resulting in an error when trying to access
Webpacker::VERSIONFix
Re add the
require 'webpacker/version'and for consistency also addrequire 'shakapacker/version'when usingShakapackerTest
I tested it on our code base and our test suite is green.
Ideally someone using
Shakapackerwould give this ago as well