Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keep css attributes in logical order (#53) #253

Merged
merged 1 commit into from
May 4, 2021

Conversation

r-Larch
Copy link
Contributor

@r-Larch r-Larch commented Apr 26, 2021

This fixes the newfound problem case of #53.

This pull request will:

  • Introduce a new public class CssAttributeCollection.
  • Changes a Public API StyleClass.Attributes { get; set; } form Dictionary<string, CssAttribute> to CssAttributeCollection while CssAttributeCollection inherits from IDictionary<string, CssAttribute>, so there should be only a minimal breaking change.

Side effect of this change:

  • Since this will keep the local order of css attributes it may also change the order of nonrelated style attributes, like: line-height and font-size as seen in PreMailer.Net/PreMailer.Net.Tests/PreMailerTests.cs

@r-Larch
Copy link
Contributor Author

r-Larch commented Apr 26, 2021

I guess this pull request could also fix #170

@martinnormark martinnormark merged commit c1c54a8 into milkshakesoftware:master May 4, 2021
@martinnormark
Copy link
Contributor

Very cool! Thanks for the PR, will try to cut a new release soon.

@meixger
Copy link

meixger commented Oct 4, 2021

@martinnormark Any chance you can make a new release?

@martinnormark
Copy link
Contributor

@meixger New release published: https://www.nuget.org/packages/PreMailer.Net/2.3.0

Sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants