feat(testnet): enable osmosis grpc #128
Conversation
WalkthroughThe changes encompass renaming and reorganizing scripts for consistency across the testnet setup. Specifically, they update script names related to initializing stake contracts and augment the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- scripts/testnet/Local-Testnet.md (1 hunks)
- scripts/testnet/local-osmosis-testnet-continue.sh (1 hunks)
Additional context used
LanguageTool
scripts/testnet/Local-Testnet.md
[uncategorized] ~19-~19: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...1lh0u9sug6qh922gjpal3frwtacaums4s7lkyl9`: Osmosis trader account used to swap the...
[uncategorized] ~20-~20: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...1sfhy3emrgp26wnzuu64p06kpkxd9phel74e0yx`: Celestia account that stakes the TIA on...
[uncategorized] ~21-~21: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...1lh0u9sug6qh922gjpal3frwtacaums4s8w5yn6`: Celestia account that operates the stak...
[uncategorized] ~22-~22: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...12rzczckgh8fqq533t0xqhqrrzdk76du3dxrx9q`: Celestia account where the staking rewa...
[uncategorized] ~110-~110: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE_2)
Context: .... - This enables Tx indexing in Celestia so tooling can confirm transactions done o...
[duplication] ~114-~114: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ... the relayer on Celestia side and store in in a file celestia-relayer-key.json ``` c...
[duplication] ~120-~120: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...r the relayer on Osmosis side and store in in a file osmosis-relayer-key.json ``` os...
[uncategorized] ~157-~157: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...er --b-port transferStart Hermes (subsequently you only need to run this command)...
[grammar] ~165-~165: It seems that a verb or a comma is missing. (MD_DT_JJ)
Context: ...rt ``` ### Check Validator output You can the output of the validators with Tmux ...
Markdownlint
scripts/testnet/Local-Testnet.md
59-59: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
18-18: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
7-7: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
13-13: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
66-66: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
76-76: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
102-102: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
116-116: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
122-122: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
128-128: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
135-135: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
143-143: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
150-150: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
159-159: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
167-167: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
179-179: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (1)
scripts/testnet/local-osmosis-testnet-continue.sh (1)
13-16: The addition of gRPC configuration options in the startup command enhances functionality as intended.Ensure that all dependent scripts and configurations are updated to handle these new gRPC settings correctly.
| @@ -38,7 +38,7 @@ Before deploying the contracts, you need to: | |||
| After completing the above steps, you can deploy the contracts by running: | |||
|
|
|||
| ```sh | |||
| ./init_stake_contract.sh | |||
| ./init-stake-contract.sh | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The old script name init_stake_contract.sh is still referenced in the Makefile. This needs to be updated to the new script name init-stake-contract.sh.
- Makefile:
bash scripts/testnet/init_stake_contract.sh
Analysis chain
The script name change from init_stake_contract.sh to init-stake-contract.sh improves consistency with naming conventions.
Ensure all documentation and references to this script across the project are updated to reflect this change.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all references to the old script name are updated.
# Search for the old script name in the entire project. Expect: No occurrences of the old script name.
rg --type md 'init_stake_contract.sh'
Length of output: 37
Script:
#!/bin/bash
# Description: Verify all references to the old script name are updated in the entire project, including non-markdown files.
# Search for the old script name in the entire project. Expect: No occurrences of the old script name.
rg 'init_stake_contract.sh'
Length of output: 81
Overview
This PR updates the
local-osmosis-testnet-continue.shscript to start the Osmosis node with the gRPC endpoint enabled.closes: #XXXX
What changes have been made in this PR?
Checklist