Supress warning from unknown and unsupported capabilities (#137)

* Supress warning from unknown capability 0x0040 * Reduce log level of unsupported capabilities
mill1000 · Jul 10, 2024 · ab34eb4 · ab34eb4
1 parent ca14268
commit ab34eb4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/msmart/device/AC/command.py b/msmart/device/AC/command.py
@@ -34,6 +34,7 @@ class CapabilityId(IntEnum):
     WIND_ON_ME = 0x0032
     WIND_OFF_ME = 0x0033
     SELF_CLEAN = 0x0039  # AKA Active Clean
+    _UNKNOWN = 0x0040  # Unknown ID from various logs
     ONE_KEY_NO_WIND_ON_ME = 0x0042
     BREEZE_CONTROL = 0x0043  # AKA "FA No Wind Sense"
     RATE_SELECT = 0x0048
@@ -511,6 +512,7 @@ def get_value(w) -> Callable[[int], bool]: return lambda v: v == w
             # CapabilityId.TEMPERATURES too complex to be handled here
             CapabilityId.WIND_OFF_ME:  reader("wind_off_me", get_value(1)),
             CapabilityId.WIND_ON_ME:  reader("wind_on_me", get_value(1)),
+            # CapabilityId._UNKNOWN is a special case
         }
 
         count = payload[1]
@@ -574,8 +576,13 @@ def apply(d, v): return {d.name: d.read(v)}
                 self._capabilities["decimals"] = (
                     caps[9] if size > 6 else caps[2]) != 0
 
+            elif capability_id == CapabilityId._UNKNOWN:
+                # Supress warnings from unknown capability
+                _LOGGER.debug(
+                    "Ignored unknown capability. ID: 0x%04X, Size: %d.", capability_id, size)
+
             else:
-                _LOGGER.warning(
+                _LOGGER.info(
                     "Unsupported capability. ID: 0x%04X, Size: %d.", capability_id, size)
 
             # Advanced to next capability

diff --git a/msmart/device/AC/test_command.py b/msmart/device/AC/test_command.py
@@ -347,12 +347,13 @@ def test_capabilities_2(self) -> None:
             "aa3dac00000000000203b50a12020101180001001402010115020101160201001a020101100201011f020100250207203c203c203c00400001000100c83a")
 
         # Test case includes an unknown capability 0x40 that generates a warning
-        with self.assertLogs("msmart") as log:
+        with self.assertLogs("msmart", logging.DEBUG) as log:
             resp = self._test_build_response(TEST_CAPABILITIES_RESPONSE)
             resp = cast(CapabilitiesResponse, resp)
 
-            # Check warning is generated for ID 0x0040
-            self.assertRegex(log.output[0], "Unknown capability. ID: 0x0040")
+            # Check debug message is generated for ID 0x0040
+            self.assertRegex("\n".join(log.output),
+                             "Ignored unknown capability. ID: 0x0040")
 
         EXPECTED_RAW_CAPABILITIES = {
             "eco_mode": True, "eco_mode_2": False, "silky_cool": False,
@@ -473,13 +474,14 @@ def test_additional_capabilities(self) -> None:
         TEST_CAPABILITIES_RESPONSE = bytes.fromhex(
             "aa3dac00000000000303b50a12020101430001011402010115020101160201001a020101100201011f020103250207203c203c203c05400001000100c805")
 
-        # Test case includes an unknown capability 0x40 that generates a warning
-        with self.assertLogs("msmart") as log:
+        # Test case includes an unknown capability 0x40 that generates a log
+        with self.assertLogs("msmart", logging.DEBUG) as log:
             resp = self._test_build_response(TEST_CAPABILITIES_RESPONSE)
             resp = cast(CapabilitiesResponse, resp)
 
-            # Check warning is generated for ID 0x0040
-            self.assertRegex(log.output[0], "Unknown capability. ID: 0x0040")
+            # Check debug message is generated for ID 0x0040
+            self.assertRegex("\n".join(log.output),
+                             "Ignored unknown capability. ID: 0x0040")
 
         EXPECTED_RAW_CAPABILITIES = {
             "eco_mode": True, "eco_mode_2": False,