Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exact test case with excess property #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Exact test case with excess property #320

wants to merge 1 commit into from

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Sep 24, 2022 •
edited
Loading

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

Adds a test case in the Function/Exact tests for excess property checking

Why have you made changes?

It was unclear whether Function/Exact supported excess property checking

What changes have you made?

  • added a test case

What tests have you updated?

  • added a test case in tests/Function

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

Ref: #319 (comment)

@karlhorky karlhorky mentioned this pull request Sep 24, 2022
Open
@karlhorky
Copy link
Author

@millsp would it be possible to get a review on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millsp millsp Awaiting requested review from millsp millsp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karlhorky