Dev #16
Dev #16
Conversation
| except (UnicodeDecodeError, exceptions.ScraperError) as e: | ||
| logger.log_debug(f"Params: {params}") | ||
| raise exceptions.ScraperError(f"Error encoding URL: {e}. ROM params: {params}") |
There was a problem hiding this comment.
Just a suggestion: since ScraperError has a log level of error, I believe it gets included in the log file even when the log level is set to info. This could lead to users accidentally leaking their passwords when they upload their log.txt file to Discord or include it in an issue. To mitigate this, I suggest filtering out sensitive information before logging. Here’s an updated (untested) code snippet:
except (UnicodeDecodeError, exceptions.ScraperError) as e:
safe_params = {k: v for k, v in params.items() if k not in ['devpassword', 'sspassword', 'ssid']}
logger.log_debug(f"Params: {safe_params}")
raise exceptions.ScraperError(f"Error encoding URL: {e}. ROM params: {safe_params}")| "output": "json", | ||
| "ssid": username, | ||
| "sspassword": password, | ||
| } | ||
| return urlunparse(urlparse(USER_INFO_URL)._replace(query=urlencode(params))) | ||
| except UnicodeDecodeError as e: |
| synopsis = game["response"]["jeu"].get("synopsis") | ||
| if not synopsis: | ||
| return None | ||
|
|
||
| synopsis_lang = config["synopsis"]["lang"] | ||
| synopsis_text = next( | ||
| (item["text"] for item in synopsis if item["langue"] == synopsis_lang), None | ||
| (item["text"] for item in synopsis if item.get("langue") == synopsis_lang), None |
There was a problem hiding this comment.
Not sure if there is a good reason not to do this or if this will even end up throwing an error if "text" doesn't exist, but just something I noticed and felt like it might help if I pointed it out. (Disclaimer: I am not too familiar with python)
| (item["text"] for item in synopsis if item.get("langue") == synopsis_lang), None | |
| (item.get("text") for item in synopsis if item.get("langue") == synopsis_lang), None |
| synopsis = game["response"]["jeu"].get("synopsis") | ||
| if not synopsis: | ||
| return None |
There was a problem hiding this comment.
Another suggestion that might not make sense, but just in case the api response is not what you expect it to be, could this be useful to do?
response = game.get("response", {})
jeu = response.get("jeu", {})
synopsis = jeu.get("synopsis")
if not synopsis:
return None
No description provided.