Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Hide buggy search iterator interface #837

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,10 @@ type Client interface {
Query(ctx context.Context, collectionName string, partitionNames []string, expr string, outputFields []string, opts ...SearchQueryOptionFunc) (ResultSet, error)
// Get grabs the inserted entities using the primary key from the Collection.
Get(ctx context.Context, collectionName string, ids entity.Column, opts ...GetOption) (ResultSet, error)
// TODO @silverxia current imlementation is buggy and cannot be released
// hide interface until fixed
// SearchIterator returns knn result in iterator mode.
SearchIterator(ctx context.Context, opt *SearchIteratorOption) (*SearchIterator, error)
// SearchIterator(ctx context.Context, opt *SearchIteratorOption) (*SearchIterator, error)
// QueryIterator returns data matches provided criterion in iterator mode.
QueryIterator(ctx context.Context, opt *QueryIteratorOption) (*QueryIterator, error)

Expand Down
Loading