Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: broadcast with event-based notification #39522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 22, 2025

issue: #38399

  • broadcast message can carry multi resource key now.
  • implement event-based notification for broadcast messages
  • broadcast message use broadcast id as a unique identifier in message
  • broadcasted message on vchannels keep the broadcasted vchannel now.
  • broadcasted message and broadcast message have a common broadcast header now.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 22, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 86.64495% with 123 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (7476eb3) to head (d75e801).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/streamingcoord/server/service/broadcast.go 23.33% 21 Missing and 2 partials ⚠️
pkg/streaming/util/message/message_impl.go 44.44% 11 Missing and 9 partials ⚠️
...al/streamingcoord/client/broadcast/grpc_watcher.go 85.03% 16 Missing and 3 partials ⚠️
...treamingcoord/client/broadcast/watcher_resuming.go 87.25% 11 Missing and 2 partials ⚠️
...amingcoord/server/broadcaster/broadcast_manager.go 92.50% 6 Missing and 3 partials ⚠️
...server/service/broadcast/broadcast_watch_server.go 88.05% 6 Missing and 2 partials ⚠️
pkg/streaming/util/message/broadcast.go 88.52% 6 Missing and 1 partial ⚠️
...ernal/streamingcoord/server/broadcaster/watcher.go 90.32% 6 Missing ⚠️
pkg/log/with_logger.go 44.44% 3 Missing and 2 partials ⚠️
pkg/streaming/util/message/builder.go 66.66% 1 Missing and 3 partials ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39522       +/-   ##
===========================================
+ Coverage   69.56%   81.05%   +11.49%     
===========================================
  Files         300     1418     +1118     
  Lines       26986   199595   +172609     
===========================================
+ Hits        18773   161788   +143015     
- Misses       8213    32096    +23883     
- Partials        0     5711     +5711     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.58% <ø> (+0.01%) ⬆️
Go 82.98% <86.49%> (∅)
Files with missing lines Coverage Δ
internal/coordinator/coordclient/registry.go 91.17% <ø> (ø)
internal/distributed/streaming/append.go 74.19% <ø> (ø)
internal/distributed/streaming/broadcast.go 100.00% <100.00%> (ø)
internal/distributed/streaming/streaming.go 100.00% <ø> (ø)
internal/distributed/streaming/wal.go 64.86% <100.00%> (ø)
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/metastore/kv/streamingcoord/kv_catalog.go 79.31% <100.00%> (ø)
internal/rootcoord/broadcast_task.go 9.61% <ø> (ø)
internal/streamingcoord/client/client.go 97.01% <100.00%> (ø)
internal/streamingcoord/client/client_impl.go 81.81% <100.00%> (ø)
... and 24 more

... and 1085 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock branch from cd1b827 to 4877b2d Compare January 22, 2025 15:15
Copy link
Contributor

mergify bot commented Jan 22, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock branch from 4877b2d to 752ff02 Compare January 23, 2025 01:43
Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

- broadcast message can carry multi resource key now.
- implement event-based notification for broadcast messages
- broadcast message use broadcast id as a unique identifier in message
- broadcasted message on vchannels keep the broadcasted vchannel now.
- broadcasted message and broadcast message have a common broadcast
  header now.

Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock branch from 752ff02 to d75e801 Compare January 23, 2025 02:41
Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

/run-cpu-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants