Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]Only check L0 compaction with same channel when stating #39543

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #39333

master pr: #39459

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 23, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaocai2333 xiaocai2333 changed the title enchace: [2.5]Only check L0 compaction with same channel when stating enhance: [2.5]Only check L0 compaction with same channel when stating Jan 23, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (6cdabd9) to head (6aaec7e).

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39543   +/-   ##
=======================================
  Coverage   80.97%   80.97%           
=======================================
  Files        1404     1404           
  Lines      198032   198031    -1     
=======================================
+ Hits       160347   160356    +9     
+ Misses      32037    32031    -6     
+ Partials     5648     5644    -4     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <ø> (ø)
Go 82.93% <75.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/task_scheduler.go 95.79% <100.00%> (+2.24%) ⬆️
internal/datacoord/task_stats.go 92.79% <100.00%> (-0.04%) ⬇️
internal/datacoord/compaction.go 70.69% <50.00%> (ø)

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 23, 2025
@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants