Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsafe concurrent consuming api of rocksmq #39544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 23, 2025

issue: #38966

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 23, 2025
@sre-ci-robot sre-ci-robot requested review from sunby and zwd1208 January 23, 2025 07:18
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 23, 2025
@chyezh chyezh force-pushed the fix_rocksmq_closing_may_block branch from 888d8d6 to 7c2fc0c Compare January 23, 2025 08:39
@chyezh chyezh added this to the 2.6.0 milestone Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (56659ba) to head (7c2fc0c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/mqimpl/rocksmq/client/client_impl.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39544      +/-   ##
==========================================
+ Coverage   80.94%   80.97%   +0.02%     
==========================================
  Files        1408     1408              
  Lines      198884   198891       +7     
==========================================
+ Hits       160987   161044      +57     
+ Misses      32194    32148      -46     
+ Partials     5703     5699       -4     
Components Coverage Δ
Client 79.51% <ø> (ø)
Core 69.56% <ø> (ø)
Go 82.89% <70.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
pkg/mq/mqimpl/rocksmq/server/rocksmq_impl.go 82.51% <100.00%> (-0.70%) ⬇️
pkg/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.89% <100.00%> (ø)
pkg/mq/mqimpl/rocksmq/client/client_impl.go 80.89% <0.00%> (-1.81%) ⬇️

... and 44 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants