Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add dsl log field for HybridSearch #39584

Merged

Conversation

congqixia
Copy link
Contributor

The dsl fields are separated in sub request structs and cannot be easiliy printed before. This PR adds a log helper to print the dsl expressions of HybridSearchRequest.

@congqixia congqixia changed the title enhance: Add dls log field for HybridSearch enhance: Add dsl log field for HybridSearch Jan 24, 2025
@sre-ci-robot sre-ci-robot requested a review from czs007 January 24, 2025 11:16
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 24, 2025
Copy link
Contributor

mergify bot commented Jan 24, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 24, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (e61a841) to head (1a3a971).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39584      +/-   ##
==========================================
+ Coverage   80.11%   80.15%   +0.04%     
==========================================
  Files        1465     1465              
  Lines      203083   203091       +8     
==========================================
+ Hits       162700   162797      +97     
+ Misses      34576    34495      -81     
+ Partials     5807     5799       -8     
Components Coverage Δ
Client 79.45% <ø> (ø)
Core 69.40% <ø> (-0.02%) ⬇️
Go 81.90% <12.50%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.76% <12.50%> (-0.10%) ⬇️

... and 37 files with indirect coverage changes

The dsl fields are separated in sub request structs and cannot be
easiliy printed before. This PR adds a log helper to print the dsl
expressions of HybridSearchRequest.

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/print_hybridsearch_dsl branch from ef7ac33 to 1a3a971 Compare January 26, 2025 02:29
Copy link
Contributor

mergify bot commented Jan 26, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 26, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 26, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit f7b7bf6 into milvus-io:master Jan 26, 2025
18 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jan 26, 2025
The dsl fields are separated in sub request structs and cannot be
easiliy printed before. This PR adds a log helper to print the dsl
expressions of HybridSearchRequest.

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants