-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add dsl log field for HybridSearch #39584
enhance: Add dsl log field for HybridSearch #39584
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia go-sdk check failed, comment |
@congqixia E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39584 +/- ##
==========================================
+ Coverage 80.11% 80.15% +0.04%
==========================================
Files 1465 1465
Lines 203083 203091 +8
==========================================
+ Hits 162700 162797 +97
+ Misses 34576 34495 -81
+ Partials 5807 5799 -8
|
The dsl fields are separated in sub request structs and cannot be easiliy printed before. This PR adds a log helper to print the dsl expressions of HybridSearchRequest. Signed-off-by: Congqi Xia <[email protected]>
ef7ac33
to
1a3a971
Compare
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
The dsl fields are separated in sub request structs and cannot be easiliy printed before. This PR adds a log helper to print the dsl expressions of HybridSearchRequest. Signed-off-by: Congqi Xia <[email protected]>
The dsl fields are separated in sub request structs and cannot be easiliy printed before. This PR adds a log helper to print the dsl expressions of HybridSearchRequest.