Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the browser debugging menu #2533

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update the browser debugging menu #2533

merged 1 commit into from
Dec 13, 2024

Conversation

PalmerAL
Copy link
Collaborator

@PalmerAL PalmerAL commented Dec 1, 2024

  • Added an option to open the devtools for the places service, which might help with debugging can't see bookmarks & history once I exit Min and restart Min. #2503.
  • Changed the browser devtools options to appear only when Min is run with the --debug-browser argument, or with the existing --development-mode.
    • Having these options appear during regular usage is somewhat confusing (it's possible to get mixed up between the browser devtools and the page devtools), and also a potential source of security issues - if someone can be convinced to paste malicious code into the browser devtools, the consequences are quite bad. I don't know of any specific instances of this happening, but it seems worthwhile to address preemptively.

Normal mode:

Screenshot 2024-12-01 at 9 04 40 AM

Debug mode:

Screenshot 2024-12-01 at 9 04 47 AM

@PalmerAL PalmerAL merged commit 7b7334c into master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant