Skip to content

Commit

Permalink
Remove remote server connection from tests -- sometimes, the connecti…
Browse files Browse the repository at this point in the history
…on dial seems to stall
  • Loading branch information
evankanderson committed Jan 30, 2025
1 parent 5f939c3 commit e08bc1e
Showing 1 changed file with 1 addition and 31 deletions.
32 changes: 1 addition & 31 deletions internal/util/cli/credentials_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TestGetGrpcConnection(t *testing.T) {
},
{
name: "Valid GRPC connection to localhost with insecure connection",
grpcHost: "127.0.0.1",
grpcHost: "localhost",
grpcPort: 8090,
allowInsecure: true,
issuerUrl: "http://localhost:8081",
Expand All @@ -87,36 +87,6 @@ func TestGetGrpcConnection(t *testing.T) {
envToken: "",
expectedError: false,
},
{
name: "Valid GRPC connection to remote server with secure connection",
grpcHost: "api.stacklok.com",
grpcPort: 443,
allowInsecure: false,
issuerUrl: "https://auth.stacklok.com",
clientId: "minder-cli",
envToken: "MINDER_AUTH_TOKEN",
expectedError: false,
},
{
name: "Valid GRPC connection to remote server with insecure connection",
grpcHost: "api.stacklok.com",
grpcPort: 443,
allowInsecure: true,
issuerUrl: "https://auth.stacklok.com",
clientId: "minder-cli",
envToken: "MINDER_AUTH_TOKEN",
expectedError: false,
},
{
name: "Valid GRPC connection to remote server without passing MINDER_AUTH_TOKEN as an argument",
grpcHost: "api.stacklok.com",
grpcPort: 443,
allowInsecure: false,
issuerUrl: "https://auth.stacklok.com",
clientId: "minder-cli",
envToken: "",
expectedError: false,
},
}

for _, tt := range tests {
Expand Down

0 comments on commit e08bc1e

Please sign in to comment.