Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Minder TestKit #4762

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Implement Minder TestKit #4762

merged 4 commits into from
Oct 17, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 16, 2024

Summary

TestKit is an implementation of several interfaces that allows for
easier testing. The intent is to be able to test rule types locally via
a programmatic framework, as opposed to relying on an integration test.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11380319738

Details

  • 53 of 63 (84.13%) changed or added relevant lines in 21 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 54.717%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/engine/eval/homoglyphs/application/homoglyphs_service.go 0 1 0.0%
internal/engine/eval/vulncheck/vulncheck.go 0 1 0.0%
internal/engine/ingester/diff/diff.go 3 7 42.86%
internal/profiles/util.go 11 15 73.33%
Files with Coverage Reduction New Missed Lines %
internal/eea/eea.go 2 73.73%
Totals Coverage Status
Change from base Build 11380297235: -0.08%
Covered Lines: 14941
Relevant Lines: 27306

💛 - Coveralls

@JAORMX JAORMX force-pushed the testkit branch 3 times, most recently from cfcaa9b to 16920e0 Compare October 16, 2024 12:08
@JAORMX JAORMX marked this pull request as ready for review October 16, 2024 13:32
@JAORMX JAORMX requested a review from jhrozek October 16, 2024 13:33
jhrozek
jhrozek previously approved these changes Oct 16, 2024
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the interfaces are nice! Feel free to fix the misnamed imports in a follow-up

jhrozek
jhrozek previously approved these changes Oct 17, 2024
TestKit is an implementation of several interfaces that allows for
easier testing. The intent is to be able to test rule types locally via
a programmatic framework, as opposed to relying on an integration test.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
It now takes a map, since that's easier to use.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit 1f78eb1 into mindersec:main Oct 17, 2024
24 of 25 checks passed
@JAORMX JAORMX deleted the testkit branch October 17, 2024 08:04
@JAORMX JAORMX restored the testkit branch October 17, 2024 10:12
@JAORMX JAORMX deleted the testkit branch October 17, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants