Dynamicrafter: mint op adaptation #765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoyangLee
requested review from
CaitinZhao,
SamitHuang and
zhanghuiyao
as code owners
CaitinZhao
reviewed
Dec 13, 2024
examples/dynamicrafter/README.md
Outdated
| | dynamicrafter | 1 | 1 | 16x576x1024 | DDIM | 50 | fp16 | O1 | 1~2 mins | 1.42 | 71 | | ||
| | dynamicrafter | 1 | 1 | 16x320x512 | DDIM | 50 | fp16 | O1 |1~2 mins | 0.42 | 21 | | ||
| | dynamicrafter | 1 | 1 | 16x256x256 | DDIM | 50 | fp16 | O1 |1~2 mins | 0.26 | 13 | | ||
| | dynamicrafter | 1 | 1 | 16x576x1024 | DDIM | 50 | fp16 | O0 | 1~2 mins | 1.56 | 78 | |
CaitinZhao
reviewed
Dec 13, 2024
| @@ -35,12 +35,12 @@ def __init__(self, *, dim, dim_head=64, heads=8): | |||
| self.heads = heads | |||
| inner_dim = dim_head * heads | |||
|
|
|||
| self.norm1 = nn.LayerNorm([dim], epsilon=1e-05) | |||
| self.norm2 = nn.LayerNorm([dim], epsilon=1e-05) | |||
| self.norm1 = mint.nn.LayerNorm([dim], eps=1e-05) | |||
There was a problem hiding this comment.
mint的weight的name应该改掉了，ckpt是不是需要刷一下
There was a problem hiding this comment.
转换ckpt时保存的参数名已相应修改：
examples/dynamicrafter/tools/ms_param_256.txt
examples/dynamicrafter/tools/ms_param_512_1024.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Update the MS CANN version in README.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx