feat(transformers): add GEMMA2 #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamitHuang
reviewed
Jan 17, 2025
Comment on lines
1
to
5
| # 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 | ||
| # This file was automatically generated from src/transformers/models/gemma2/modular_gemma2.py. | ||
| # Do NOT edit this file manually as any edits will be overwritten by the generation of | ||
| # the file from the modular. If any change should be done, please apply the change to the | ||
| # modular_gemma2.py file directly. One of our CI enforces this. |
There was a problem hiding this comment.
may remove this comment?
|
|
||
| if past_key_value is not None: | ||
| raise NotImplementedError( | ||
| "Gemma2 is only used as diffusers text-encoder and will not be called sequently, it need no cache." |
| position_ids: Optional[ms.Tensor] = None, | ||
| past_key_value: Optional[Cache] = None, | ||
| output_attentions: bool = False, | ||
| use_cache: bool = False, |
There was a problem hiding this comment.
May add docstring to claim use_cache is not supported
|
参考检视意见，已：
|
CaitinZhao
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
-Gemma2 report-
Add Gemma2 to MindONE transformers, for MindONE diffusers text-encoder
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx