PXP-635: [CLI] Terminate the TUI when there is a panic on TUI #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk-gan
reviewed
Nov 22, 2023
| Some(s) => *s, | ||
| None => match panic_info.payload().downcast_ref::<String>() { | ||
| Some(s) => &s[..], | ||
| None => "Box<Any>", |
There was a problem hiding this comment.
This was originally taken from here
As my understanding was that its a placeholder to match the string return types
jk-gan
approved these changes
Nov 22, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jk-gan, mfauzaan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a panic occurs in the Wukong CLI, the panic message is displayed on the TUI screen and breaks the TUI rendering and makes it TUI unusable.
To address this issue, a panic hook has been implemented to capture TUI errors and ensure a safe exit. Additionally, network panics needs to be handled on a case-by-case basis, providing relevant error messages to users in the corresponding panel.
Ticket: https://mindvalley.atlassian.net/browse/PXP-635
What's Changed