DX-805 get and show pod connection details for livebook smart cell #228
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fadhil
force-pushed
the
feature/show-smart-cell-details
branch
from
2ded9f0 to
00d38a6
Compare
jk-gan
reviewed
Oct 1, 2024
jk-gan
approved these changes
Oct 2, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fadhil, jk-gan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we update the kubernetes_pod query to additionally get the
node_nameandcookiefor the pod and display those values along with a short instruction on how the user can connect to a selected node.Ticket: DX-805
The changes in action:
Testing out the provided details in a livebook:
What's Changed
Show pod connection details and instructions on how to use them in the
application instances connectflowUpdated schema and kubernetes_pods.graphql to get
node_nameandcookie