This repository has been archived by the owner on May 13, 2024. It is now read-only.
Fix undefined behaviors #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getActiveIcon() may be called before ActiveIcon is initialized, leading to undefined behavior.
appgurueu
reviewed
Feb 11, 2024
fuzun
force-pushed
the
undefinedbehaviorfix
branch
from
797edbc to
6a51e01
Compare
appgurueu
approved these changes
Feb 11, 2024
header struct is packed, and `core::max_()` takes the input as reference.
fuzun
force-pushed
the
undefinedbehaviorfix
branch
from
6a51e01 to
10e2e62
Compare
sfan5
reviewed
Feb 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes two undefined behaviors found by using Undefined Behavior Sanitizer.