Fix default User-Agent regression #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent HTTP client refactor in 14e25ab introduced a bug in which the global default User-Agent is no longer used for requests. Unless a per-feed User-Agent exists, the Go standard library's default User-Agent is used, which looks something like "Go-http-client/1.1". To fix this, make RequestBuilder.WithUserAgent take an additional argument, the default User-Agent, which will be used if there is no per-feed User-Agent (i.e. it is an empty string). Fixes miniflux#2188 Fixes miniflux#2189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent HTTP client refactor in 14e25ab introduced a bug in which the global default User-Agent is no longer used for requests. Unless a per-feed User-Agent exists, the Go standard library's default User-Agent is used, which looks something like "Go-http-client/1.1". To fix this, make RequestBuilder.WithUserAgent take an additional argument, the default User-Agent, which will be used if there is no per-feed User-Agent (i.e. it is an empty string).
Fixes #2188
Fixes #2189
Do you follow the guidelines?