Add cpio magic filename TRAILER!!! #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://entropymine.wordpress.com/2018/05/27/the-cpio-trailer-problem/ makes a great point, cpio gives special meaning to certain filenames. Add that to list.
I'm not regenerating the generated code because, frankly, they were already out of date, the build system is a hot mess, there's two different variants for creating the Go source, etc. Fixing all that would belong in a separate PR, and even more to the point would take some technical leadership & stating the vision; what's the scope of the project etc.