Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Dark Mode in Console #3129

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Enabled Dark Mode in Console #3129

merged 2 commits into from
Nov 15, 2023

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Nov 14, 2023

What does this do?

  • Dark mode will be tied to system settings if not set
  • Dark mode will be stored in Application storage once set

How does it look?

Screenshot 2023-11-14 at 3 48 44 p m Screenshot 2023-11-14 at 1 51 44 p m Screenshot 2023-11-14 at 1 50 02 p m Screenshot 2023-11-14 at 1 49 48 p m Screenshot 2023-11-14 at 1 49 35 p m Screenshot 2023-11-14 at 1 49 27 p m Screenshot 2023-11-14 at 1 49 19 p m

cesnietor
cesnietor previously approved these changes Nov 14, 2023
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

- Dark mode will be tied to system settings if not set
- Dark mode will be stored in Application storage once set

Signed-off-by: Benjamin Perez <[email protected]>
Copy link
Member

@dilverse dilverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@bexsoft bexsoft merged commit 044c265 into minio:master Nov 15, 2023
28 of 30 checks passed
@bexsoft bexsoft deleted the enable-dark-mode branch November 15, 2023 19:33
@pjuarezd
Copy link
Member

pjuarezd commented Nov 15, 2023

As a color blind was asked to do a review on the Dark mode, gladly sharing what I found:

  • The red color in the warning message is a bit difficult to read, lacking a little more of contrast with backgroun, this might only uncomfortable to people in the Red deficit spectrum of color blindess people. Make it bold or choose a different red

Screenshot 2023-11-15 at 1 01 30 PM

ie: this contrast level works fine to me

Screenshot 2023-11-15 at 1 08 28 PM

  • This green color is OK, can see well, just feels a little bit too much contrast because of the brigtness, almost like a car in front of ou with high beams in the night, drags all of the attention
    Screenshot 2023-11-15 at 1 09 16 PM

This green tone feels nicer, maybe even a bit more opaque
Screenshot 2023-11-15 at 1 11 56 PM

Screenshot 2023-11-15 at 1 13 46 PM

Not even on hover
Screenshot 2023-11-15 at 1 15 26 PM

  • The red color is perfectly acceptable for the graph, it's just a bit lack on contrast to read on the legend for "Before Healing" label, perhaps keepping the color block and chage the font to the same other text elements have like bucketname

Screenshot 2023-11-15 at 1 25 35 PM

  • No complain, just wanted to share I love it!, I love how logos were added with a background white shadow
    Screenshot 2023-11-15 at 1 29 32 PM

  • Too drak blue, too bright green on this icons, the checkmarks draws all the attention and the actual action goes in unspotted.

Screenshot 2023-11-15 at 1 34 02 PM

  • Not to mention that links are just too hard to even notice they are there
    Screenshot 2023-11-15 at 1 35 20 PM

  • This is not preciselly color blind related, but the "Restart" button seems off to me, maybe a mater of taste, but as the buttons feel like if they were transparent over a blue background or white backgroun, shouldn't this button be yellow background as well?

Screenshot 2023-11-15 at 1 49 54 PM

cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Dark mode will be tied to system settings if not set
- Dark mode will be stored in Application storage once set

Signed-off-by: Benjamin Perez <[email protected]>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Dark mode will be tied to system settings if not set
- Dark mode will be stored in Application storage once set

Signed-off-by: Benjamin Perez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants