Changed PDF file preview behavior #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
pjuarezd,
cniackz,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
adriangitvitz,
jinapurapu and
dilverse
dvaldivia
previously approved these changes
Dec 2, 2023
cesnietor
reviewed
Dec 4, 2023
bexsoft
force-pushed
the
test-pdf-transition
branch
from
9f8debe to
852bbe3
Compare
|
Seems that now we can't preview txt files @bexsoft. We used to can in the previous version. |
bexsoft
force-pushed
the
test-pdf-transition
branch
2 times, most recently
from
55745d1 to
40756e5
Compare
Done |
bexsoft
force-pushed
the
test-pdf-transition
branch
from
40756e5 to
11a3fc5
Compare
cesnietor
previously approved these changes
Dec 11, 2023
bexsoft
force-pushed
the
test-pdf-transition
branch
from
1db0f3b to
7dc47a3
Compare
|
@bexsoft , could you fix the react warnings as reported in CI ? |
Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
test-pdf-transition
branch
from
7dc47a3 to
f72cafc
Compare
reivaj05
approved these changes
Dec 12, 2023
|
@bexsoft Looks like node is installing as 16.20.2, while playwright is expecting >=18. The playwright tests did not run it seems. Did something change? |
This is related to github workflow, will review in a further PR |
cesnietor
approved these changes
Dec 12, 2023
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Benjamin Perez <[email protected]>
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Benjamin Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Changed PDF preview behavior
How does it look?