Change KMSKeyInfo.CreatedAt to a time.Time

[marktheunissen]

Discussion here: minio/minio#20223 (comment)

Other pull requests:

• https://github.com/minio/madmin-go/pull/296/files

[marktheunissen]

Don't know why this JS build is failing in the CI...

[ramondeklein]

We had the same failure in EOS console since yesterday, so looks like an external issue.

[ramondeklein]

This should fix the Javascript action: #3423

[marktheunissen]

@cesnietor govet complained about errorsApi.ServeError(w, req, errorsApi.New(http.StatusUnauthorized, err.Error())) which was not something I touched in the PR.

I have just pushed a commit to change that to errorsApi.ServeError(w, req, errorsApi.New(http.StatusUnauthorized, "%s", err.Error())) which will probably fix the linting, but ultimately doesn't do anything, as the .New() call handled it fine before.

Another option is to change the linter configuration, let me know.

[ramondeklein]

@marktheunissen We've seen this in more repositories. It looks like the most recent golangci-lint version is more strict. We have issued PRs for both MinIO and mc already. Note that this is in fact a proper warning that needs fixing.

[ramondeklein]

I have just pushed a commit to change that to errorsApi.ServeError(w, req, errorsApi.New(http.StatusUnauthorized, "%s", err.Error())) which will probably fix the linting, but ultimately doesn't do anything, as the .New() call handled it fine before.

I think it warns, because there could be some unexpected behavior when the error message contains formatting instructions, such as %1000d or some other extreme stuff. Not sure if it could cause a crash when %s is used without passing any arguments...

[harshavardhana]

Please look at a more comprehensive update @marktheunissen at #3425

[marktheunissen]

@ramondeklein I don't disagree.... :) generally speaking, the vetting is correct.

My comment was just about this specific case, where the function being called is errorsApi.New() which is:

// New creates a new API error with a code and a message
func New(code int32, message string, args ...interface{}) Error {
	if len(args) > 0 {
		return &apiError{
			code:    code,
			message: fmt.Sprintf(message, args...),
		}
	}
	return &apiError{
		code:    code,
		message: message,
	}
}

My comment was " the .New() call handled it fine before.". What I meant is that passing 0 args bypasses the call to fmt.Sprintf, but the linter doesn't know that. Edge case I suppose

@harshavardhana has completed this work in the PR #3425 so I'll close this, thanks!