Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for kes 2023-10-24T20-26-51Z #45

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Update for kes 2023-10-24T20-26-51Z #45

merged 2 commits into from
Dec 29, 2023

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Dec 29, 2023

Adds information about Transit functionality.

Closes #44

Adds information about Transit functionality.

Closes #1048
@djwfyi djwfyi requested review from feorlen, ravindk89 and aead December 29, 2023 20:09
@djwfyi djwfyi self-assigned this Dec 29, 2023
This provides an additional layer of encryption that may be useful in specific use cases.

When enabled, Hashicorp stores a key in the Vault to encrypt or decrypt the other keys stored in the vault.
KES then uses the vault-managed key to store or retrieve keys from the Vault.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KES then uses the vault-managed key to store or retrieve keys from the Vault.
KES then uses the vault-managed key to store or retrieve keys from the Vault.
If the specified transit key is incorrect, disabled, removed, or otherwise unaccessible, KES cannot retrieve any vault keys nor perform any en/decryption operations relying on those keys.

I assume this is true at least and is worth a warning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good suggestion!

Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional nit, otherwise LGTM

@djwfyi djwfyi merged commit 72ab753 into main Dec 29, 2023
@djwfyi djwfyi deleted the transit branch December 29, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] kes 2023-10-24T20-26-51Z
2 participants