Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid crash when approle is not used #421

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: Avoid crash when approle is not used #421

merged 1 commit into from
Nov 10, 2023

Conversation

vadmeste
Copy link
Member

No description provided.

@kannappanr kannappanr requested review from aead and shtripat November 10, 2023 07:47
@aead
Copy link
Member

aead commented Nov 10, 2023

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

@aead aead merged commit 2e9975b into minio:master Nov 10, 2023
7 checks passed
@shtripat
Copy link
Contributor

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

Agree, as with latest kes I see that these errors get caught while loading the config file itself. Anyway its good to have nil check added here.

@vadmeste
Copy link
Member Author

vadmeste commented Nov 10, 2023 •
edited
Loading

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

master can reproduce this. I think it is enough if you use kubernetes auth; in that case c.AppRole will be nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@aead aead Awaiting requested review from aead

@shtripat shtripat Awaiting requested review from shtripat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadmeste @aead @shtripat @harshavardhana