add HMAC API and use KMS secret key crypto #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
hmac
branch
6 times, most recently
from
3deaf30 to
8998d19
Compare
This commit does two closely related things: - It replaces the existing AES/ChaCha20 secret key implementation with a newer one based on the MinIO KMS implementation. - Adds an HMAC API such that clients can compute a HMAC checksum over a message. The new secret key implementation is located in the `internal/crypto` package. It is fully backwards compatible with the previous implementation that resided in `internal/key` and is removed by this PR. In particular, all ciphertexts produced with existing keys can be decrypted with the added implementation. The new implementation cleans up some design issues in the previous AES-256 and ChaCha20 ciphertext generation: - Now, ciphertexts have no structure or format. They only consist of the AEAD ciphertext (encrypted plaintext + auth. tag) and the 224 bit (28 byte) nonce. - Forward and backward compatibility information is no longer embedded into the ciphertext but instead into the key. For example, if we ever want to update the AES scheme, e.g. from AES-GCM or AES-SIV, (which we never did btw) we just create a new secret key type. This has also the side effect of ciphertexts getting significantly smaller (half the size). Since each MinIO object embeds at least one ciphertext in its metadata, this can give be a small perf. improvement when listing a lot of encrypted objects. *** The new HMAC API allows clients to compute a deterministic keyed checkusm (MAC) over some data without having direct access to the HMAC key. Clients may use this to verify that messages are authentic or generate the same pseudo-random secret on startup. Signed-off-by: Andreas Auernhammer <[email protected]>
harshavardhana
approved these changes
Jan 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two closely related things:
The new secret key implementation is located in the
internal/cryptopackage. It is fully backwards compatible with the previous implementation that resided ininternal/keyand is removed by this PR. In particular, all ciphertexts produced with existing keys can be decrypted with the added implementation.The new implementation cleans up some design issues in the previous AES-256 and ChaCha20 ciphertext generation:
This has also the side effect of ciphertexts getting significantly smaller (half the size). Since each MinIO object embeds at least one ciphertext in its metadata, this can give be a small perf. improvement when listing a lot of encrypted objects.
The new HMAC API allows clients to compute a deterministic keyed checkusm (MAC) over some data without having direct access to the HMAC key. Clients may use this to verify that messages are authentic or generate the same pseudo-random secret on startup.