vault: renew token earlier #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
vault-token-renewal
branch
from
447ba08 to
3d1093b
Compare
vadmeste
reviewed
Aug 21, 2024
ramondeklein
approved these changes
Aug 21, 2024
aead
force-pushed
the
vault-token-renewal
branch
2 times, most recently
from
a2d46c2 to
dc4cf65
Compare
vadmeste
approved these changes
Aug 22, 2024
This commit changes the Vault token renewal logic to renew a token earlier than 10s before it expires. Now, KES renews the token once 80% of the token TTL has passed. This commit also adds a `context.Context` to the Vault authentication function. Signed-off-by: Andreas Auernhammer <[email protected]>
aead
force-pushed
the
vault-token-renewal
branch
from
dc4cf65 to
e8dffb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Vault token renewal logic to renew a token earlier than 10s before it expires. Now, if the token has a TTL > than 1m (or 30s) the token is renewed 1m (or 30s) before it expires.
This commit also adds a
context.Contextto the Vault authentication function.