Skip to content

Commit

Permalink
Use map[string]string for THP config
Browse files Browse the repository at this point in the history
  • Loading branch information
anjalshireesh committed Jan 19, 2024
1 parent fc2cf40 commit 9815370
Showing 1 changed file with 13 additions and 24 deletions.
37 changes: 13 additions & 24 deletions health.go
Original file line number Diff line number Diff line change
Expand Up @@ -489,33 +489,22 @@ func readIntFromFile(filePath string) (num int, err error) {
return strconv.Atoi(strings.TrimSpace(string(data)))
}

func getTHPConfigs() map[string]interface{} {
configs := map[string]interface{}{}
data, err := os.ReadFile("/sys/kernel/mm/transparent_hugepage/enabled")
if err != nil {
configs["enabled_error"] = err.Error()
} else {
configs["enabled"] = strings.TrimSpace(string(data))
}

data, err = os.ReadFile("/sys/kernel/mm/transparent_hugepage/defrag")
if err != nil {
configs["defrag_error"] = err.Error()
} else {
configs["defrag"] = strings.TrimSpace(string(data))
}
func getTHPConfigs() map[string]string {
configs := map[string]string{}
captureTHPConfig(configs, "/sys/kernel/mm/transparent_hugepage/enabled", "enabled")
captureTHPConfig(configs, "/sys/kernel/mm/transparent_hugepage/defrag", "defrag")
captureTHPConfig(configs, "/sys/kernel/mm/transparent_hugepage/khugepaged/max_ptes_none", "max_ptes_none")
return configs
}

data, err = os.ReadFile("/sys/kernel/mm/transparent_hugepage/khugepaged/max_ptes_none")
func captureTHPConfig(configs map[string]string, filePath string, cfgName string) {
errFieldName := "cfgName" + "_error"
data, err := os.ReadFile(filePath)
if err != nil {
configs["max_ptes_none_error"] = err.Error()
} else {
configs["max_ptes_none"], err = strconv.Atoi(strings.TrimSpace(string(data)))
if err != nil {
configs["max_ptes_none_error"] = err.Error()
}
configs[errFieldName] = err.Error()
return
}

return configs
configs[cfgName] = strings.TrimSpace(string(data))
}

func getXFSErrorMaxRetries() XFSErrorConfigs {
Expand Down

0 comments on commit 9815370

Please sign in to comment.