Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tier: Add validation to tier configuration #256

Merged
merged 1 commit into from
Dec 21, 2023
Merged

tier: Add validation to tier configuration #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cgroup/nolinux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ package cgroup
import "errors"

// GetMemoryLimit - Not implemented in non-linux platforms
func GetMemoryLimit(pid int) (limit uint64, err error) {
func GetMemoryLimit(_ int) (limit uint64, err error) {
return limit, errors.New("Not implemented for non-linux platforms")
}
8 changes: 7 additions & 1 deletion tier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,14 @@ func (adm *AdminClient) ListTiers(ctx context.Context) ([]*TierConfig, error) {
type TierCreds struct {
AccessKey string `json:"access,omitempty"`
SecretKey string `json:"secret,omitempty"`

AWSRole bool `json:"awsrole"`
AWSRoleWebIdentityTokenFile string `json:"awsroleWebIdentity,omitempty"`
AWSRoleARN string `json:"awsroleARN,omitempty"`

AzSP ServicePrincipalAuth `json:"azSP,omitempty"`

CredsJSON []byte `json:"creds,omitempty"`
AWSRole bool `json:"awsrole"`
}

// EditTier supports updating credentials for the remote tier identified by tierName.
Expand Down
Loading