Add length check for empty policy content #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an empty file used as input for policy creation a zero sized byte array gets passed. Corrected the check to see length and if it's zero, error out. Earlier error was confusing as below ``` mc: <ERROR> Unable to create new policy. You must provide the Content-Length HTTP header. ``` Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
empty-policy-check
branch
from
7e53ad4 to
4f2c78a
Compare
harshavardhana
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an empty file used as input for policy creation a zero sized byte array gets passed. Corrected the check to see length and if it's zero, error out.
Fixes: minio/mc#5108