Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax in examples #4834

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix syntax in examples #4834

merged 4 commits into from
Jan 31, 2024

Conversation

Fexiven
Copy link
Contributor

@Fexiven Fexiven commented Jan 29, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

There was a minor synax mistake where the custom json and the bucket location was swapped

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

The custom-policy.json and location was swapped. I also removed the prefix example for this one, should be clear to whoever uses it.
Replace the name of the the policy state
@Fexiven
Copy link
Contributor Author

Fexiven commented Jan 29, 2024

#4761 the USAGE section was updated, the examples not

cmd/anonymous-main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit e21762b into minio:master Jan 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants