Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy entities now print group memberships per user #4961

Merged
merged 9 commits into from
Aug 17, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Jun 12, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

mc idp ldap policy entities now prints group memberships for queried users. The combined effective policies of the user+group is also printed as "Effective Policies". This also occurs for mc admin policy entities

Currently there are two options for displaying this information:
OPTION 1 - Delimited by commas with wrapping at 80 characters
image

OPTION 2 - All entries on separate lines
image

Motivation and Context

minio/minio#20052

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@taran-p taran-p marked this pull request as ready for review July 18, 2024 22:37
@donatello
Copy link
Member

I'm ok with option 2 as it is mainly for presentation. Programmatic access is available via the json option.

@harshavardhana harshavardhana changed the title Policy Entities update policy entities now print group memberships per user Aug 17, 2024
@harshavardhana harshavardhana merged commit 2c94b8d into minio:master Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants