Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Bucket created confirmation message if bucket creation failed #5107

Closed

Conversation

jinapurapu
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Skips displaying "Bucket created successfully" confirmation if bucket creation fails.

Motivation and Context

Before, UI displayed "Bucket created successfully" confirmation despite failure of bucket creation. Confirmation no longer displayed if bucket creation fails.

Before
Screenshot 2025-01-13 at 3 04 25 PM

Screenshot 2025-01-13 at 3 02 09 PM ## How to test this PR? Attempt to create a bucket in an incorrect way (ex - "mc mb ALIAS BUCKETNAME" vs "mc mb ALIAS/BUCKETNAME"). No bucket should be created (can verify with mc ls), and only error message should show.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mc mb works the same as mkdir for local filesystem. So when multiple args are given it will try to create all the buckets given. So in this case it's more of a user error.

@jinapurapu
Copy link
Contributor Author

mc mb works the same as mkdir for local filesystem. So when multiple args are given it will try to create all the buckets given. So in this case it's more of a user error.

Yes, but in the error case it still was confirming that the bucket was created when it was not, printing both the correct error and the incorrect confirmation message.

@donatello
Copy link
Member

badbucket would have been created as a local directory. So the success part of the message is also correct

@jinapurapu jinapurapu closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants