Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exceptions returned from BucketExistsAsync #1120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoyalScribblz
Copy link

@RoyalScribblz RoyalScribblz commented Jul 1, 2024

Fixes #1118

Throw exceptions returned in the response as BucketNotFoundException is already caught.

@RoyalScribblz RoyalScribblz changed the title #1118 throw exceptions returned from BucketExistsAsync Throw exceptions returned from BucketExistsAsync Jul 1, 2024
@michaelwv
Copy link

Any estimated date for releasing this bugfix?

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BucketExistsAsync must be returning false and no exceptions when bucket does not exist.

Please add a functional test to cover this scenario // cc @ebozduman

@ebozduman
Copy link
Collaborator

Checking the code and the existing test to see what is missing to capture the thrown exception as a failure...

@albracko
Copy link

Just to add here..all API methods should be checked not just this one, because Error Handling for other API methods is also wrong

@COCPORN
Copy link

COCPORN commented Jul 18, 2024

I also ran into this. If the AccessKey or SecretKey is wrong, checking if a bucket exists returns true.

@ebozduman
Copy link
Collaborator

@RoyalScribblz , @michaelwv, @albracko , @COCPORN
I appreciate it if you could test and verify the fix, #1141 (not merged yet as of 07/24 23:42), against your scenarios.
If you are satisfied with your testing, you/I can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BucketExistsAsync returns true even if it does not exist
7 participants