Data race: Use a copy instead of a pointer to url.URL (#1126)

minio · Jun 21, 2019 · bb942b2 · bb942b2
1 parent f389a72
commit bb942b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bucket-cache.go b/bucket-cache.go
@@ -170,7 +170,7 @@ func (c Client) getBucketLocationRequest(bucketName string) (*http.Request, erro
 	urlValues.Set("location", "")
 
 	// Set get bucket location always as path style.
-	targetURL := c.endpointURL
+	targetURL := *c.endpointURL
 
 	// as it works in makeTargetURL method from api.go file
 	if h, p, err := net.SplitHostPort(targetURL.Host); err == nil {

diff --git a/bucket-cache_test.go b/bucket-cache_test.go
@@ -73,7 +73,7 @@ func TestGetBucketLocationRequest(t *testing.T) {
 		urlValues.Set("location", "")
 
 		// Set get bucket location always as path style.
-		targetURL := c.endpointURL
+		targetURL := *c.endpointURL
 		targetURL.Path = path.Join(bucketName, "") + "/"
 		targetURL.RawQuery = urlValues.Encode()