Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bucket throttle configuration struct #1909

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions pkg/throttle/throttle.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
/*
* MinIO Go Library for Amazon S3 Compatible Cloud Storage
* Copyright 2020 MinIO, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

// Package lifecycle contains all the lifecycle related data types and marshallers.

Check failure on line 18 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.19.x and ubuntu-latest

package-comments: package comment should be of the form "Package throttle ..." (revive)

Check failure on line 18 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.21.x and ubuntu-latest

package-comments: package comment should be of the form "Package throttle ..." (revive)
package throttle

import (
"encoding/json"
"encoding/xml"
//"errors"

Check failure on line 24 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.19.x and ubuntu-latest

commentFormatting: put a space between `//` and comment text (gocritic)

Check failure on line 24 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.21.x and ubuntu-latest

commentFormatting: put a space between `//` and comment text (gocritic)
//"time"
)

// MarshalJSON customizes json encoding by omitting empty values
func (r Rule) MarshalJSON() ([]byte, error) {
type rule struct {
ConcurrentRequestsCount uint64 `json:"ConcurrentRequestsCount,omitempty"`
APIs string `json:"APIs",omitempty`

Check failure on line 32 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.19.x and ubuntu-latest

structtag: struct field tag `json:"APIs",omitempty` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

Check failure on line 32 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.21.x and ubuntu-latest

structtag: struct field tag `json:"APIs",omitempty` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)
ID string `json:"ID"`
}
newr := rule{
ConcurrentRequestsCount: r.ConcurrentRequestsCount,
APIs: r.APIs,
ID: r.ID,
}

return json.Marshal(newr)
}

// Rule represents a single rule in throttle configuration
type Rule struct {
XMLName xml.Name `xml:"Rule,omitempty" json:"-"`
ConcurrentRequestsCount uint64 `xml:"ConcurrentRequestsCount" json:"ConcurrentRequestsCount"`

Check failure on line 47 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.19.x and ubuntu-latest

File is not `goimports`-ed (goimports)

Check failure on line 47 in pkg/throttle/throttle.go

View workflow job for this annotation

GitHub Actions / Test on Go 1.21.x and ubuntu-latest

File is not `goimports`-ed (goimports)
APIs string `xml:"APIs" json:"APIs"`
ID string `xml:"ID" json:"ID"`
}

// Configuration is a collection of Rule objects.
type Configuration struct {
XMLName xml.Name `xml:"ThrottleConfiguration,omitempty" json:"-"`
Rules []Rule `xml:"Rule"`
}

// Empty check if lifecycle configuration is empty
func (c *Configuration) Empty() bool {
if c == nil {
return true
}
return len(c.Rules) == 0
}

// NewConfiguration initializes a fresh lifecycle configuration
// for manipulation, such as setting and removing lifecycle rules
// and filters.
func NewConfiguration() *Configuration {
return &Configuration{}
}
Loading